Use dialect.name in custom SA types
#33503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
requested review from
eladkal,
ephraimbuddy,
kaxil,
potiuk and
uranusjr
potiuk
approved these changes
Aug 18, 2023
hussein-awala
approved these changes
Aug 18, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Use `dialect.name` in custom SA types * Fix removed import (cherry picked from commit 46aa429)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use our custom SA types, we use global settings instead of
sqlalchemy.engine.Dialectas result in some circumstances users might have performance degradation, see: #33172 (comment)cc: @vchiapaikeo
closes: #33485
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.