Refactor: Simplify conditions on len()

airflow/cli/commands/pool_command.py

@@ -97,7 +97,7 @@ def pool_import(args):
     if not os.path.exists(args.file):
         raise SystemExit(f"Missing pools file {args.file}")
     pools, failed = pool_import_helper(args.file)
-    if len(failed) > 0:
+    if failed:
         raise SystemExit(f"Failed to update pool(s): {', '.join(failed)}")
     print(f"Uploaded {len(pools)} pool(s)")
 

airflow/cli/commands/webserver_command.py

@@ -138,7 +138,7 @@ def _get_num_ready_workers_running(self) -> int:
         def ready_prefix_on_cmdline(proc):
             try:
                 cmdline = proc.cmdline()
-                if len(cmdline) > 0:
+                if cmdline:
                     return settings.GUNICORN_WORKER_READY_PREFIX in cmdline[0]
             except psutil.NoSuchProcess:
                 pass

airflow/dag_processing/processor.py

@@ -826,7 +826,7 @@ def process_file(
             Stats.incr("dag_file_refresh_error", 1, 1, tags={"file_path": file_path})
             return 0, 0
 
-        if len(dagbag.dags) > 0:
+        if dagbag.dags:
             self.log.info("DAG(s) %s retrieved from %s", dagbag.dags.keys(), file_path)
         else:
             self.log.warning("No viable dags retrieved from %s", file_path)

airflow/listeners/listener.py

@@ -46,7 +46,7 @@ def __init__(self):
 
     @property
     def has_listeners(self) -> bool:
-        return len(self.pm.get_plugins()) > 0
+        return bool(self.pm.get_plugins())
 
     @property
     def hook(self) -> _HookRelay:

airflow/models/baseoperator.py

@@ -391,7 +391,7 @@ def apply_defaults(self: BaseOperator, *args: Any, **kwargs: Any) -> Any:
             from airflow.models.dag import DagContext
             from airflow.utils.task_group import TaskGroupContext
 
-            if len(args) > 0:
+            if args:
                 raise AirflowException("Use keyword arguments when initializing operators")
 
             instantiated_from_mapped = kwargs.pop(

airflow/models/dag.py

@@ -1583,7 +1583,7 @@ def get_task_instances_before(
             .limit(num)
         ).all()
 
-        if len(execution_dates) == 0:
+        if not execution_dates:
             return self.get_task_instances(start_date=base_date, end_date=base_date, session=session)
 
         min_date: datetime | None = execution_dates[-1]._mapping.get(
@@ -3146,7 +3146,7 @@ def deactivate_unknown_dags(active_dag_ids, session=NEW_SESSION):
         :param active_dag_ids: list of DAG IDs that are active
         :return: None
         """
-        if len(active_dag_ids) == 0:
+        if not active_dag_ids:
             return
         for dag in session.scalars(select(DagModel).where(~DagModel.dag_id.in_(active_dag_ids))).all():
             dag.is_active = False

airflow/sensors/filesystem.py

@@ -70,6 +70,6 @@ def poke(self, context: Context):
                 return True
 
             for _, _, files in os.walk(path):
-                if len(files) > 0:
+                if files:
                     return True
         return False

airflow/triggers/file.py

@@ -68,6 +68,6 @@ async def run(self) -> typing.AsyncIterator[TriggerEvent]:
                     self.log.info("Found File %s last modified: %s", str(path), str(mod_time))
                     yield TriggerEvent(True)
                 for _, _, files in os.walk(self.filepath):
-                    if len(files) > 0:
+                    if files:
                         yield TriggerEvent(True)
             await asyncio.sleep(self.poll_interval)

airflow/www/extensions/init_jinja_globals.py

@@ -74,7 +74,7 @@ def prepare_jinja_globals():
         }
 
         backends = conf.get("api", "auth_backends")
-        if len(backends) > 0 and backends[0] != "airflow.api.auth.backend.deny_all":
+        if backends and backends[0] != "airflow.api.auth.backend.deny_all":
             extra_globals["rest_api_enabled"] = True
 
         if "analytics_tool" in conf.getsection("webserver"):

airflow/www/fab_security/manager.py

@@ -521,7 +521,7 @@ def _search_ldap(self, ldap, con, username):
             self.auth_ldap_lastname_field,
             self.auth_ldap_email_field,
         ]
-        if len(self.auth_roles_mapping) > 0:
+        if self.auth_roles_mapping:
             request_fields.append(self.auth_ldap_group_field)
 
         # perform the LDAP search
@@ -561,7 +561,7 @@ def _ldap_calculate_user_roles(self, user_attributes: dict[str, list[bytes]]) ->
         user_role_objects = set()
 
         # apply AUTH_ROLES_MAPPING
-        if len(self.auth_roles_mapping) > 0:
+        if self.auth_roles_mapping:
             user_role_keys = self.ldap_extract_list(user_attributes, self.auth_ldap_group_field)
             user_role_objects.update(self.get_roles_from_keys(user_role_keys))
 
@@ -852,7 +852,7 @@ def _oauth_calculate_user_roles(self, userinfo) -> list[str]:
         user_role_objects = set()
 
         # apply AUTH_ROLES_MAPPING
-        if len(self.auth_roles_mapping) > 0:
+        if self.auth_roles_mapping:
             user_role_keys = userinfo.get("role_keys", [])
             user_role_objects.update(self.get_roles_from_keys(user_role_keys))
 

airflow/www/views.py

@@ -3857,7 +3857,7 @@ def dataset_dependencies(self):
 
         for dag, dependencies in SerializedDagModel.get_dag_dependencies().items():
             dag_node_id = f"dag:{dag}"
-            if dag_node_id not in nodes_dict and len(dependencies) > 0:
+            if dag_node_id not in nodes_dict:
                 for dep in dependencies:
                     if dep.dependency_type == "dag" or dep.dependency_type == "dataset":
                         nodes_dict[dag_node_id] = node_dict(dag_node_id, dag, "dag")

dev/breeze/src/airflow_breeze/utils/coertions.py

@@ -30,4 +30,4 @@ def coerce_bool_value(value: str | bool) -> bool:
 
 
 def one_or_none_set(iterable: Iterable[bool]) -> bool:
-    return sum(1 for i in iterable if i) in (0, 1)
+    return 0 <= sum(1 for i in iterable if i) <= 1