Fix DagFileProcessor interfering with dags outside its processor_subdir
#33357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
XD-DENG,
ashb,
ephraimbuddy,
jedcunningham and
kaxil
as code owners
boring-cyborg
bot
added
area:Scheduler
pierrejeambrun
changed the title
processor_subdir
pierrejeambrun
force-pushed
the
fix/33310-dag-file-processor-deleted-dags-with-subdir
branch
from
20f7763 to
6f56a96
Compare
potiuk
approved these changes
Aug 13, 2023
Member
|
Nice catch! |
uranusjr
reviewed
Aug 14, 2023
Member
Author
|
Comment was addressed, merging |
pierrejeambrun
deleted the
fix/33310-dag-file-processor-deleted-dags-with-subdir
branch
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
…bdir`` (apache#33357) * Fix standalone DagProcessor interfering with DAG outsite of its subdir * Add tests * Update code review
97 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #33310
DagFileProcessorManager._refresh_dag_dirshould not interfer withSerializedDagModel,DagModelorDagCodeoutside of itsdag_directory.Cf original issue but this mostly cause other dags to get wrongly deactivated by other standalone DagProcessor. I assume this can also cause some scheduling delay if the deactivation of the dag happens at the wrong timing.