Fix pydantic warning about orm_mode rename
#33220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pydantic 2 renamed orm_mode to from_attributes. This was missed during the upgrade to pydantic 2 and it gives excessive warning about the rename. This PR fixes it
ephraimbuddy
added
changelog:skip
potiuk
approved these changes
Aug 8, 2023
jedcunningham
approved these changes
Aug 8, 2023
ephraimbuddy
force-pushed
the
rename-orm-mode
branch
from
f500479 to
765f87f
Compare
Contributor
Author
|
Looks like we can't fix this due to breeze having pydantic 1. |
Member
|
Why don't we simply limit pydantic to <2 for now ? |
Member
|
#33235 - PR ready for review |
Member
|
I added a commit to make this compatible with both Pydantic 1.x and 2.x. |
ephraimbuddy
added a commit
that referenced
this pull request
Aug 28, 2023
* Fix pydantic warning about `orm_mode` rename Pydantic 2 renamed orm_mode to from_attributes. This was missed during the upgrade to pydantic 2 and it gives excessive warning about the rename. This PR fixes it * Also rename from_orm to model_validate and use model_dump instead of dict * Fix Pydantic 1.x compatibility --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 75bb04b)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic 2 renamed orm_mode to from_attributes. This was missed during the upgrade to pydantic 2 and it gives excessive warnings about the rename. This PR fixes it