Handle login by auth managers #32697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
ashb,
bbovenzi,
ephraimbuddy,
jhtimmins,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
vincbeck
added
AIP-56
vincbeck
force-pushed
the
vincbeck/login
branch
5 times, most recently
from
0ec29f1 to
ef004ea
Compare
uranusjr
reviewed
Jul 20, 2023
uranusjr
reviewed
Jul 20, 2023
uranusjr
approved these changes
Jul 20, 2023
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Looks good, just a couple to nitpicks that don’t affect the logic at all.
Contributor
Author
o-nikolas
approved these changes
Jul 24, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the login logic to auth managers.
Resolves #32192
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.