Skip to content

Add missing execute_complete method for DatabricksRunNowOperator #32689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phanikumv merged 3 commits into from
Jul 24, 2023
Merged

Add missing execute_complete method for DatabricksRunNowOperator #32689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65e3ebe
fix(providers/databricks): add missing execute_complete method for Da…
Lee-W Jul 19, 2023
72e7046
refactor(providers/databricks): remove unnecessary execute_complete i…
Lee-W Jul 20, 2023
f5f15d8
test(providers/databrick): fix execute_complete test cases
Lee-W Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions airflow/providers/databricks/operators/databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,10 @@ def execute(self, context: Context):
else:
_handle_databricks_operator_execution(self, hook, self.log, context)

def execute_complete(self, context: Context, event: dict[str, Any] | None = None) -> None:
if event:
_handle_deferrable_databricks_operator_completion(event, self.log)

def on_kill(self):
if self.run_id:
self._hook.cancel_run(self.run_id)
Expand Down Expand Up @@ -698,6 +702,3 @@ def execute(self, context):
hook = self._get_hook(caller="DatabricksRunNowDeferrableOperator")
self.run_id = hook.run_now(self.json)
_handle_deferrable_databricks_operator_execution(self, hook, self.log, context)

def execute_complete(self, context: dict | None, event: dict):
_handle_deferrable_databricks_operator_completion(event, self.log)
4 changes: 2 additions & 2 deletions tests/providers/databricks/operators/test_databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ def test_execute_complete_failure(self, db_mock_class):
op.execute_complete(context=None, event=event)

def test_execute_complete_incorrect_event_validation_failure(self):
event = {}
event = {"event_id": "no such column"}
op = DatabricksSubmitRunDeferrableOperator(task_id=TASK_ID)
with pytest.raises(AirflowException):
op.execute_complete(context=None, event=event)
Expand Down Expand Up @@ -951,7 +951,7 @@ def test_execute_complete_failure(self, db_mock_class):
op.execute_complete(context=None, event=event)

def test_execute_complete_incorrect_event_validation_failure(self):
event = {}
event = {"event_id": "no such column"}
op = DatabricksRunNowDeferrableOperator(task_id=TASK_ID, job_id=JOB_ID)
with pytest.raises(AirflowException):
op.execute_complete(context=None, event=event)