-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Chart: template dagprocessor waitformigrations extraVolumeMounts #32100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: template dagprocessor waitformigrations extraVolumeMounts #32100
Conversation
|
Can you add test coverage for this as well? Thanks. |
|
@jedcunningham, I added the tests, please take a look. Looks like the failing check is not related to this PR. |
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of updates on chart tests which are not related to this change, maybe we should move them to a separate PR and keep only dag-processor tests in this one.
@jedcunningham wdyt?
|
I'd say updates on chart tests are somewhat related to this change - I just modified the tests so they would test templating of extraVolumeMounts/extraVolumes for all components, not just for dagProcessor. But if you do think it would be better to separate the changes, please tell me - I'll move changes not related to dag-processor to a separate PR. |
Yeah. Those tests changes seem related, I ofen use opportunities like that to generally improve test code. Seems that thos test change still test what they were supposed to test (but better) and there is no functional change to the airflow code, so very little risk with having them in single PR. |
|
WDYT @hussein-awala @jedcunningham ? |
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if you do think it would be better to separate the changes, please tell me
No objection on my part, LGTM
Looks like #30990 got a bit mixed up with #30773 and the extraVolumeMounts of dagprocessor wait for migrations init container are not templated, while other extraVolumeMounts are templated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.