Skip to content

Conversation

@Aakcht
Copy link
Contributor

@Aakcht Aakcht commented Jun 23, 2023

Looks like #30990 got a bit mixed up with #30773 and the extraVolumeMounts of dagprocessor wait for migrations init container are not templated, while other extraVolumeMounts are templated.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@jedcunningham
Copy link
Member

Can you add test coverage for this as well? Thanks.

@Aakcht
Copy link
Contributor Author

Aakcht commented Jun 24, 2023

@jedcunningham, I added the tests, please take a look. Looks like the failing check is not related to this PR.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of updates on chart tests which are not related to this change, maybe we should move them to a separate PR and keep only dag-processor tests in this one.
@jedcunningham wdyt?

@Aakcht
Copy link
Contributor Author

Aakcht commented Jun 26, 2023

I'd say updates on chart tests are somewhat related to this change - I just modified the tests so they would test templating of extraVolumeMounts/extraVolumes for all components, not just for dagProcessor. But if you do think it would be better to separate the changes, please tell me - I'll move changes not related to dag-processor to a separate PR.

@potiuk
Copy link
Member

potiuk commented Jun 27, 2023

I'd say updates on chart tests are somewhat related to this change

Yeah. Those tests changes seem related, I ofen use opportunities like that to generally improve test code. Seems that thos test change still test what they were supposed to test (but better) and there is no functional change to the airflow code, so very little risk with having them in single PR.

@potiuk
Copy link
Member

potiuk commented Jun 27, 2023

WDYT @hussein-awala @jedcunningham ?

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if you do think it would be better to separate the changes, please tell me

No objection on my part, LGTM

@potiuk potiuk merged commit c4790df into apache:main Jun 27, 2023
@Aakcht Aakcht deleted the template_dag_processor_migration_volumes branch June 28, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants