-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Allow downloading requirements file from GCS in BeamRunPythonPipelineOperator
#31645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to add a test for your change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have a py_file which doesn't start with gs:// with a requirement file stored in gcs in the same job? if yes (and I think it's yes), your code will try to download the two files from gcs.
Instead, you can create a method to download an object from gcs, and use it for py_file and/or requirements file:
def _get_file_from_gcs(self, object_url):
gcs_hook = GCSHook(gcp_conn_id=self.gcp_conn_id)
return exit_stack.enter_context(gcs_hook.provide_file(object_url=object_url))and in this method:
if self.py_file.lower().startswith("gs://"):
self.py_file = self._get_file_from_gcs(self.py_file).name
if snake_case_pipeline_options.get('requirements_file', '').startswith("gs://"):
snake_case_pipeline_options['requirements_file'] = self._get_file_from_gcs(snake_case_pipeline_options['requirements_file']).nameWDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, i'll do that instead
BeamRunPythonPipelineOperator
currently only python file support gcs download, however, requirement.txt might also benefit from that
|
@yupbank could you check the failed tests? |
currently only python file support gcs download, however, requirement.txt might also benefit from that
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.