Skip PythonVirtualenvOperator task when it returns a provided exit code #30690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Apr 17, 2023
uranusjr
reviewed
Apr 17, 2023
| templates_dict: dict | None = None, | ||
| templates_exts: list[str] | None = None, | ||
| expect_airflow: bool = True, | ||
| skip_exit_code: int | None = None, |
Member
There was a problem hiding this comment.
I’m late but this name feels like it’s skipping the exit code; would it be better to name it e.g. skip_on_exit_code instead? Also would it be a good idea to allow multiple codes?
Member
Author
There was a problem hiding this comment.
yes, good suggestions, I'll create a new PR to address them
wookiist
pushed a commit
to wookiist/airflow
that referenced
this pull request
Apr 19, 2023
…de (apache#30690) * Add a new argument to rais skip exception when the python callable exit with the same value * add unit tests for skip_exit_code
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 19, 2023
The change #apache#30690 and apache#30692 added skip_on_exit_code to the PythonVirtualenvOperator, but it skipped the - very closely related - ExternalPythonOperator. This change brings the same functionality to ExternalPythonOperator, moves it to the base class for both operators, it also adds separate Test class for ExternalPythonOperator, also introducing a common base class and moving the test methods that are common to both operators there.
potiuk
added a commit
that referenced
this pull request
Apr 19, 2023
The change ##30690 and #30692 added skip_on_exit_code to the PythonVirtualenvOperator, but it skipped the - very closely related - ExternalPythonOperator. This change brings the same functionality to ExternalPythonOperator, moves it to the base class for both operators, it also adds separate Test class for ExternalPythonOperator, also introducing a common base class and moving the test methods that are common to both operators there.
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 21, 2023
The change ##30690 and #30692 added skip_on_exit_code to the PythonVirtualenvOperator, but it skipped the - very closely related - ExternalPythonOperator. This change brings the same functionality to ExternalPythonOperator, moves it to the base class for both operators, it also adds separate Test class for ExternalPythonOperator, also introducing a common base class and moving the test methods that are common to both operators there. (cherry picked from commit 5ed4669)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
PythonVirtualenvOperatortask when the python callable returns the exit codeskip_exit_codeprovided as an argument.