-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Clean microsoft azure provider by deleting the custom prefix from conn extra fields #30558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We also have entry for Azure in #28790 |
|
The method airflow/airflow/providers/microsoft/azure/hooks/fileshare.py Lines 29 to 33 in 058b6eb
I don't think we really need to wait until bumping the provider min airflow version to >= 2.5.0, since we check for the two variables (with and without
WDYT? |
|
Hmm. I think the problem was that without the "ensure prefixes" providers_manager woudl crash during building the UI fir connections or at least wreak some havoc. I think we would need to build such provder and install it in airflow 2.3 to be sure. |
|
After defining connection with 2.3 of course. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
a377d60 to
6a91ecb
Compare
|
@potiuk I tested this PR with 2.4.0 (the current min version) and with main, I can create connections with and without the
There is no problems with the UI: |
|
I can't remember exactly (the comment was from more than 3 months ago) but I believe it was based on "providers back-compat tests" failing back then. We moved to 2.4 min version since, so I think this is good to go now - maybe because of back-compat problem going away because of the min-airflow version bump :) |



closes: #30557
In this PR I fix the UI fields name by removing the custom prefix from Azure conn extra fields, deprecating the used fields with this prefix in order to remove them in the future, clean the documentation, and clean the provider tests.