Skip to content

Conversation

@oboki
Copy link
Contributor

@oboki oboki commented Mar 26, 2023

I think it would be nice to add an option (tls_verify) to choose whether or not to validate the provided certificate.

closes: #30309


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 26, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@oboki oboki force-pushed the feature-for-docker-tls-verify branch from b39e0d1 to 100eb86 Compare March 27, 2023 22:07
@oboki oboki requested a review from hussein-awala April 2, 2023 00:04
@hussein-awala hussein-awala added this to the Airflow 2.6.0 milestone Apr 13, 2023
@eladkal eladkal removed this from the Airflow 2.6.0 milestone Apr 14, 2023
@eladkal
Copy link
Contributor

eladkal commented Apr 14, 2023

no need for milestone this PR is on the provider release cycle :)

@eladkal eladkal merged commit c1a685f into apache:main Apr 14, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 14, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

wookiist pushed a commit to wookiist/airflow that referenced this pull request Apr 19, 2023
…er to validate certificate (apache#30309) (apache#30310)

* add `tls_verify` to choose whether to validate certificate (apache#30309)

---------

Co-authored-by: Hussein Awala <hussein@awala.fr>
@ephraimbuddy ephraimbuddy added this to the Airflow 2.6.0 milestone Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in DockerOperator, adding an attribute tls_verify to choose whether to validate the provided certificate.

4 participants