Merge BigQueryTableExistencePartitionAsyncSensor into BigQueryTableExistencePartitionSensor #30231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ableExistencePartitionAsyncSensor to BigQueryTableExistencePartitionSensor
…itionSensor when its deferrable attribute is set to True
boring-cyborg
bot
added
area:providers
area:system-tests
kind:documentation
provider:google
Lee-W
changed the title
uranusjr
reviewed
Mar 22, 2023
…itionSensor deferrable mode and BigQueryTableExistencePartitionAsyncSensor deprecation
…r sync and async mode in BigQueryTableExistencePartitionSensor
Lee-W
force-pushed
the
merge-BigQueryTableExistencePartitionAsyncSensor-into-BigQueryTableExistencePartitionSensor
branch
from
78aa648 to
7ec1131
Compare
uranusjr
reviewed
Mar 22, 2023
Comment on lines
+153
to
+154
| if deferrable and "poke_interval" not in kwargs: | ||
| kwargs["poke_interval"] = 5 |
Member
There was a problem hiding this comment.
Don’t need to be done in this PR but should be a good idea to define 5 as a constant somewhere (maybe BaseSensorOperator.DEFERRABLE_POLL_INTERVAL) so we don’t repeat the magic number everywhere.
Member
Author
There was a problem hiding this comment.
I just noticed AzureDataFactoryPipelineRunStatusAsyncSensor using 60 instead of 5. Do you think we still should add this constant in this case?
uranusjr
approved these changes
Mar 22, 2023
potiuk
approved these changes
Mar 22, 2023
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why making this change?
apache-airflow-providers-google treats the deferred execution of its operators and sensors differently, which might cause confusion. For example, BigQueryCheckOperator uses the deferrable parameter to toggle deferred execution while we need to use another sensor for BigQueryTablePartitionExistenceSensor (i.e., BigQueryTablePartitionExistenceAsyncSensor) to achieve the same thing.
What's changed?
In this pull request, I move the deferred logic from BigQueryTablePartitionExistenceAsyncSensor to BigQueryTablePartitionExistenceSensor so that we can keep the consistency and reduce maintenance effort. Instead of removing BigQueryTablePartitionExistenceAsyncSensor, I add a deprecation warning in case users're using it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.