Merge DbtCloudJobRunAsyncSensor logic to DbtCloudJobRunSensor #30227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
merge-async-logic-from-DbtCloudJobRunAsyncSensor-to-DbtCloudJobRunSensor
branch
from
11f6807 to
a58bc04
Compare
Lee-W
force-pushed
the
merge-async-logic-from-DbtCloudJobRunAsyncSensor-to-DbtCloudJobRunSensor
branch
2 times, most recently
from
599ef53 to
abc5998
Compare
…unAsyncSensor to DbtCloudJobRunSensor
… deferrable attribute is set to True
Lee-W
force-pushed
the
merge-async-logic-from-DbtCloudJobRunAsyncSensor-to-DbtCloudJobRunSensor
branch
from
abc5998 to
a428e5d
Compare
Lee-W
commented
Mar 22, 2023
uranusjr
reviewed
Mar 23, 2023
Lee-W
force-pushed
the
merge-async-logic-from-DbtCloudJobRunAsyncSensor-to-DbtCloudJobRunSensor
branch
from
d5de0ca to
31044d0
Compare
Member
Author
|
@uranusjr Does it timeout again? If so, could you please help rerun it? Thanks! |
josh-fell
reviewed
Mar 28, 2023
Contributor
josh-fell
left a comment
josh-fell
left a comment
There was a problem hiding this comment.
A much-need consolidation indeed! Just a few small comments.
Contributor
There was a problem hiding this comment.
Would you mind including this note in a .. note:: directive? The formatting of the docs with a Note would put some emphasis around the deprecation.
Let's remove the code snippet example below too since that example shows a deprecated sensor.
Member
Author
There was a problem hiding this comment.
sure! I just update it. I'm not sure whether we can remove the code snippet. If my memory serves me right, it won't pass the CI.
josh-fell
reviewed
Mar 28, 2023
…le mode and DbtCloudJobRunAsyncSensor deprecation
…t_cloud_run_job_sensor_defered
Lee-W
force-pushed
the
merge-async-logic-from-DbtCloudJobRunAsyncSensor-to-DbtCloudJobRunSensor
branch
from
fdfd23b to
a774320
Compare
Member
Author
|
HI @josh-fell , I've tried to address all the comments. Could you please take a look when you have time? Thanks! |
josh-fell
approved these changes
Apr 4, 2023
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why making this change?
apache-airflow-providers-dbt-cloud treats the deferred execution of its operators and sensors differently, which might cause confusion. For example, DbtCloudRunJobOperator uses the deferrable parameter to toggle deferred execution while we need to use another sensor for DbtCloudJobRunSensor (i.e., DbtCloudJobRunAsyncSensor) to achieve the same thing.
What's changed?
In this pull request, I move the deferred logic from DbtCloudJobRunAsyncSensor to DbtCloudJobRunSensor so that we can keep the consistency and reduce maintenance effort. Instead of removing DbtCloudJobRunSensor, I add a deprecation warning in case there're users using it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.