Fix HDFSHook HAClient is invalid #30164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trickysky
changed the title
Contributor
Author
|
Another code implementation: |
Member
|
I think we need a unit test covering it to prevent regressions. It's suspicious not see tests modified/added/fixed with such a change |
Contributor
Author
I modify a bad unit test, @potiuk please take a look, thanks |
trickysky
commented
Mar 22, 2023
| def test_get_ha_client(self, mock_get_connections): | ||
| conn_1 = Connection(conn_id="hdfs_default", conn_type="hdfs", host="localhost", port=8020) | ||
| conn_2 = Connection(conn_id="hdfs_default", conn_type="hdfs", host="localhost2", port=8020) | ||
| mock_get_connections.return_value = [conn_1, conn_2] |
Contributor
Author
There was a problem hiding this comment.
Connection model conn_id field is unique
potiuk
approved these changes
Mar 22, 2023
Member
|
Needs static checks fixing though (you can install/run pre-commit to fix those). |
|
Awesome work, congrats on your first merged pull request! |
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseHook.get_connections is deprecated, only return one connection
snakebite HAClient need more than one connection
HAClient