Update scripts to make our pgbouncer-related scripts multiplatform #30054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
fix-multi-platform-images-for-pgbouncers
branch
from
41868f5 to
a6a94f5
Compare
potiuk
force-pushed
the
fix-multi-platform-images-for-pgbouncers
branch
from
a6a94f5 to
ef1c18c
Compare
jedcunningham
approved these changes
Mar 13, 2023
The images were traditionally amd-only and they are used by the Helm Chart, however this means that if someone uses the chart on ARM, they have an emulated performance (16x slower or so). This change switches our scripts to use the buildx and qemu (by default installed with Docker Desktop) to build and push multiplatform images. Fixes: apache#29967
potiuk
force-pushed
the
fix-multi-platform-images-for-pgbouncers
branch
from
ef1c18c to
5708f2c
Compare
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The images were traditionally amd-only and they are used by the Helm Chart, however this means that if someone uses the chart on ARM, they have an emulated performance (16x slower or so).
This change switches our scripts to use the buildx and qemu (by default installed with Docker Desktop) to build and push multiplatform images.
Fixes: #29967
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.