Reformat chart templates part 2

[dnskr]

The PR reformats multiple chart templates as the continuation of #29917

[jedcunningham]

Overall LGTM. Spotted some indents that might need to be nindents, but it may not matter?

Did you intentionally skip the pod_template_file template?

[dnskr]

Hi @jedcunningham!

Overall LGTM. Spotted some indents that might need to be nindents, but it may not matter?

They should not be nindented because it will add one extra new line, i.e. the following

          envFrom: {{- include "custom_airflow_environment_from" . | default "\n  []" | nindent 10 }}
          env: {{- include "custom_airflow_environment" . | nindent 10 }}

produces

          envFrom:

            - secretRef:
                name: 'test-airflow-connections'
            - configMapRef:
                name: 'test-airflow-variables'

          env:

            # Dynamically created environment variables
            - name: qwe
              value: "rty"
            # Dynamically created secret envs
            # Extra env
            - name: AIRFLOW__CORE__LOAD_EXAMPLES
              value: 'True'

while current implementation

          envFrom: {{- include "custom_airflow_environment_from" . | default "\n  []" | indent 10 }}
          env: {{- include "custom_airflow_environment" . | indent 10 }}

produces

          envFrom:
            - secretRef:
                name: 'test-airflow-connections'
            - configMapRef:
                name: 'test-airflow-variables'

          env:
            # Dynamically created environment variables
            - name: qwe
              value: "rty"
            # Dynamically created secret envs
            # Extra env
            - name: AIRFLOW__CORE__LOAD_EXAMPLES
              value: 'True'

---

Did you intentionally skip the pod_template_file template?

I skipped pod-template-file.kubernetes-helm-yaml accidently and most of _helpers.yaml intentionally for now.

[jedcunningham]

I skipped pod-template-file.kubernetes-helm-yaml accidently and most of _helpers.yaml intentionally for now.

👍

it will add one extra new line

Ah. Can those helpers not emit an extra leading newline instead? If you want to defer to when you tackle helpers, that's cool too.

[dnskr]

Ah. Can those helpers not emit an extra leading newline instead? If you want to defer to when you tackle helpers, that's cool too.

I don't know to be honest. I want to investigate it and refactor helpers separately.

[dnskr]

Fixed merge conflict introduced by commit e60be9e