custom waiters with dynamic values, applied to appflow #29911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vandonr-amz
force-pushed
the
vandonr/waiter
branch
from
9cde188 to
676f022
Compare
vincbeck
requested changes
Mar 6, 2023
Taragolis
reviewed
Mar 7, 2023
ferruzzi
approved these changes
Mar 14, 2023
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Nice clean implementation 👍
| "expected": "blah", | ||
| "matcher": "path", | ||
| "state": "success", | ||
| "argument": "{{not a valid jinja template 💀}}" |
| f"Parameter was not supplied for templated waiter's acceptor '{arg}'", e | ||
| ) | ||
| return config | ||
|
|
Contributor
There was a problem hiding this comment.
Yeah. I think I like this solution. I could nitpick the variable names but I always do that. :P
o-nikolas
approved these changes
Mar 21, 2023
Contributor
|
@vincbeck and @Taragolis are you happy with the changes in response to your comments? |
potiuk
approved these changes
Mar 21, 2023
vincbeck
approved these changes
Mar 21, 2023
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a mechanism to allow custom waiters to take dynamic values at runtime by editing the waiter config on the fly
argumentfield, which describes what's checked, this is the only place where we replace themapply this new capability in transforming appflow
wait_for_completioncode to use a waiter (follow-up on rewrite polling code for appflow hook #28869)