Skip to content

Fixing broken filter in /taskinstance/list view #29850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 4 commits into from
Mar 10, 2023
Merged

Fixing broken filter in /taskinstance/list view #29850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fcdad4
Use hybrid_property for ti.try_number to fix broken filterin in taski…
SamWheating Mar 2, 2023
0106655
fixes for static checks
SamWheating Mar 2, 2023
4253270
Add comment / todo to explain hybrid_property mypy trick
SamWheating Mar 3, 2023
61e62ae
Update airflow/models/taskinstance.py
SamWheating Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion airflow/models/taskinstance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,13 @@
from airflow.models.operator import Operator
from airflow.utils.task_group import MappedTaskGroup, TaskGroup

# This is a workaround because mypy doesn't work with hybrid_property
# TODO: remove this hack and move hybrid_property back to main import block
# See https://github.com/python/mypy/issues/4430
hybrid_property = property
else:
from sqlalchemy.ext.hybrid import hybrid_property


PAST_DEPENDS_MET = "past_depends_met"

Expand Down Expand Up @@ -561,7 +568,7 @@ def init_on_load(self) -> None:
self._log = logging.getLogger("airflow.task")
self.test_mode = False # can be changed when calling 'run'

@property
@hybrid_property
def try_number(self):
"""
Return the try number that this task number will be when it is actually
Expand Down
13 changes: 13 additions & 0 deletions tests/www/views/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,19 @@ def test_task_start_date_filter(admin_client, url, content):
check_content_in_response(content, resp)


@pytest.mark.parametrize(
"url",
[
"/taskinstance/list/?_flt_1_try_number=0", # greater than
"/taskinstance/list/?_flt_2_try_number=5", # less than
],
)
def test_try_number_filter(admin_client, url):
resp = admin_client.get(url)
# Ensure that the taskInstance view can filter on gt / lt try_number
check_content_in_response("List Task Instance", resp)


@pytest.mark.parametrize(
"url, content",
[
Expand Down