AWS Glue job hook: Make s3_bucket parameter optional #29659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
|
cc: @vincbeck @syedahsn @ferruzzi @vandonr-amz - can you please review this if you've a chance? |
Contributor
|
There are some static check failures though. Please read documentation in order to fix them. |
Contributor
Author
|
@vincbeck I have pushed fixes, checks are currently running it should be ok after |
vandonr-amz
approved these changes
Feb 21, 2023
Contributor
vandonr-amz
left a comment
vandonr-amz
left a comment
There was a problem hiding this comment.
yeah good for me too, though a committer will have to give binding approval :)
eladkal
approved these changes
Feb 21, 2023
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #29423