Handle deleting more than 256 blobs using WasbHook.delete_file()
#29565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently users cannot delete more than 256 blobs in a single `WasbHook.delete_file()` call per limits of the [`ContainerClient.delete_blobs()` API](https://learn.microsoft.com/en-us/python/api/azure-storage-blob/azure.storage.blob.containerclient?view=azure-python#azure-storage-blob-containerclient-delete-blobs). This PR introduces batching of these delete requests such that the maximum number of blobs to delete is 256 while users only need to call `WasbHook.delete_file()` only once (this is also applicable for the WasbDeleteBlobOperator).
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
eladkal
approved these changes
Feb 16, 2023
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently users cannot delete more than 256 blobs in a single
WasbHook.delete_file()call per limits of theContainerClient.delete_blobs()API. This PR introduces batching of these delete requests such that the maximum number of blobs to delete is 256 while users only need to callWasbHook.delete_file()only once (this is also applicable for the WasbDeleteBlobOperator).