-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Get rid of state in Apache Beam provider hook #29503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
Hi @dannikay! Thanks for contributing! Would you mind providing more context to why this change is desired here please? |
|
Hi @josh-fell #15536 is the context. I remembered that I wrote the issue ID somewhere in the PR (the PR template requires me to fill it in) but I could not find it being displayed anywhere. |
|
Locally triggered "breeze static-checks --all-files --show-diff-on-failure --color always" and it passes with the new patch. |
|
breeze static-checks --all-files --show-diff-on-failure --color always --type run-mypy --all-files Package pre_commit is installed. Good version 3.0.4 (>= 2.0.0) Good version of Docker: 23.0.1. My last run silently failed mypy check due to version mismatch between my local breeze (3.8) and the CI (3.7). |
Mypy always runs with 3.7 (no matter what you use locally to run breeze) |
josh-fell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool refactor. One trivial comment update, but overall LGTM.
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
Thanks! Applied the suggestion and all checks passed again. |
|
Awesome work, congrats on your first merged pull request! |
|
@dannikay Woohoo! Great work in your first contribution! 🎉 |
|
Thank you for your reviews, @josh-fell ! |
Closes: #15536
Get rid of state in Apache Beam provider hook
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.