Skip to content

Conversation

@dannikay
Copy link
Contributor

@dannikay dannikay commented Feb 13, 2023

Closes: #15536
Get rid of state in Apache Beam provider hook


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 13, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@josh-fell
Copy link
Contributor

Hi @dannikay! Thanks for contributing! Would you mind providing more context to why this change is desired here please?

@dannikay
Copy link
Contributor Author

Hi @josh-fell #15536 is the context. I remembered that I wrote the issue ID somewhere in the PR (the PR template requires me to fill it in) but I could not find it being displayed anywhere.

@dannikay
Copy link
Contributor Author

Locally triggered "breeze static-checks --all-files --show-diff-on-failure --color always" and it passes with the new patch.

@dannikay
Copy link
Contributor Author

breeze static-checks --all-files --show-diff-on-failure --color always --type run-mypy --all-files
Checking pre-commit installed for /root/.local/pipx/venvs/apache-airflow-breeze/bin/python

Package pre_commit is installed. Good version 3.0.4 (>= 2.0.0)

Good version of Docker: 23.0.1.
Good version of docker-compose: 2.16.0
Good Docker context used: default.
Run mypy for dev.........................................................Passed
Run mypy for core........................................................Passed
Run mypy for providers...................................................Passed
Run mypy for /docs/ folder...............................................Passed

My last run silently failed mypy check due to version mismatch between my local breeze (3.8) and the CI (3.7).

@potiuk
Copy link
Member

potiuk commented Feb 16, 2023

My last run silently failed mypy check due to version mismatch between my local breeze (3.8) and the CI (3.7).

Mypy always runs with 3.7 (no matter what you use locally to run breeze)

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool refactor. One trivial comment update, but overall LGTM.

Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
@dannikay
Copy link
Contributor Author

Very cool refactor. One trivial comment update, but overall LGTM.

Thanks! Applied the suggestion and all checks passed again.

@josh-fell josh-fell merged commit 7ba27e7 into apache:main Feb 17, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 17, 2023

Awesome work, congrats on your first merged pull request!

@josh-fell
Copy link
Contributor

@dannikay Woohoo! Great work in your first contribution! 🎉

@dannikay
Copy link
Contributor Author

Thank you for your reviews, @josh-fell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of state in Apache Beam provider hook

3 participants