Use rfc3339 compatible datetime in Param validation #29374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
force-pushed
the
param-rfc3339-datetime
branch
from
0c4fb47 to
f758275
Compare
potiuk
approved these changes
Feb 4, 2023
Contributor
Author
|
One part fixed another part broken, classic. I will have a look later in a day what can I do with REST API |
Taragolis
force-pushed
the
param-rfc3339-datetime
branch
from
f758275 to
842b4e7
Compare
The open-api-schema-validator 0.4.3 made RFC3339 validation of the date-time fields mandatory and this revealed problems in our test URLs - the '+' was not url-encoded and it was replaced with space - thus the dates passed were not valid RFC3339 date-time specifications. This however revealed one more problem. The RFC3339-validator package is automatically installed by the open-api-schema-validator, but when installed, it also adds validation to date-time fields validated by the Params of ours - for example naive date-time parameters are not supported any more (but they were in the past). This might introduce breaking changes for users who use non-valid date-time parameters - however we should consider that as a bugfix, and accidental support, because the date-time schema should expect RFC3999-formatted date time.
and make valid iso8601 as compatible deprecated format
Taragolis
force-pushed
the
param-rfc3339-datetime
branch
from
842b4e7 to
51594ba
Compare
Contributor
Author
|
closed in favor of #29395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our canary build/test failed on validation date-time param, the reason new version of
openapi-schema-validatornow userfc3339-validator, and this change behaviour forjsonschemavalidation.List of changes applied by this PR:
jsonschemato 4+, in this versionjsonschemadrop supportstrict-rfc3339and only userfc3339-validatorif it installed. This mostly for avoid to use another rfc3339 validation method.rfc3339-validatoras core dependency