Increase max height for grid view elements #29367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:UI
eladkal
approved these changes
Feb 4, 2023
jedcunningham
approved these changes
Feb 5, 2023
pierrejeambrun
added
the
type:misc/internal
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
(cherry picked from commit 643d736)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
(cherry picked from commit 643d736)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.5.0, I set the max height for the grid view to be too restricted which hurt UX. This PR basically doubles the
maxHeightto allow a user to see more of the grid at once but without scrolling the entire page so far as to lose context.Fixes: #29100
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.