Clarify description of worker control config #29247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Jan 30, 2023
The description mentioned SQS which is not currently officially supported as broker. However this config could be used in case of (potentially) any broker that does not support remote control. In order to not make false impression that SQS is supported, we should remove the specific reference.
potiuk
force-pushed
the
clarify-config-description-for-remote-control
branch
from
9a4f8ce to
bbec953
Compare
jedcunningham
approved these changes
Jan 30, 2023
pierrejeambrun
added
the
type:misc/internal
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
The description mentioned SQS which is not currently officially supported as broker. However this config could be used in case of (potentially) any broker that does not support remote control. In order to not make false impression that SQS is supported, we should remove the specific reference. (cherry picked from commit 5a1dc9e)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
The description mentioned SQS which is not currently officially supported as broker. However this config could be used in case of (potentially) any broker that does not support remote control. In order to not make false impression that SQS is supported, we should remove the specific reference. (cherry picked from commit 5a1dc9e)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description mentioned SQS which is not currently officially supported as broker. However this config could be used in case of (potentially) any broker that does not support remote control.
In order to not make false impression that SQS is supported, we should remove the specific reference.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.