Provide the missing connection id for the parent classes of snowflake operators #29211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:snowflake
potiuk
approved these changes
Jan 29, 2023
Member
|
Nice! Thanks @hussein-awala |
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #29198
In the operators
SnowflakeCheckOperator,SnowflakeValueCheckOperatorandSnowflakeIntervalCheckOperatorwe are extending some operators from the provider common SQL, but we don't provide the snowflake connection id to the parent class. In this PR, I'm using thesnowflake_conn_idas a connection id for the parent operator.