shorten poke intervals on systems tests #29183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorten sleep time on athena sys test. 2 minutes faster. set shorter polling times of fast ops in batch sys test - 4min faster shorter polling on cloudformation systest - 1min30s faster shorter polling time on lambda sys test - 1 min faster shorter wait on quicksight shorter waits for sagemaker test shorten wait time for setp_functions, 50s faster shorter wait on dms. This one is important so that we don't miss the running status
vincbeck
requested changes
Jan 26, 2023
ferruzzi
approved these changes
Jan 26, 2023
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Other than Vincent's comments, which I agree with, I think it LGTM
vincbeck
approved these changes
Jan 26, 2023
o-nikolas
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since #28528 was merged, we respect the polling times instead of pinging the API constantly. This means that some tests that have sensors that used to wait for a very short time are now taking a lot longer because they wait for nothing.
I went through the "duration" metric for system tests, and looked at the ones that had a noticeable increase in run time in the last runs, then adapted the poke intervals to adapt them to the actual waiting time.
shorten sleep time on athena sys test. 2 minutes faster.
set shorter polling times of fast ops in batch sys test - 4min faster
shorter polling on cloudformation systest - 1min30s faster
shorter polling time on lambda sys test - 1 min faster
shorter wait on quicksight
shorter waits for sagemaker test
shorten wait time for setp_functions, 50s faster
shorter wait on dms. This one is important so that we don't miss the running status
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.