Fix KubernetesPodOperator xcom push when get_logs=False
#29052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
2 tasks
Member
|
LGTM but I think I need also second opinion (@jedcunningham :) again )? I also think having unit tests covering the cases that would have failed previously are needed here. I am always suspicious about changes introducing behavioural change where no tests are touched. |
potiuk
approved these changes
Feb 19, 2023
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Approved. @jedcunningham @dstandish ?
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
LGTM, but yes we should add test coverage.
jedcunningham
approved these changes
Feb 25, 2023
Member
Author
|
@eladkal is it too late to add this fix to cncf.kubernetes release? |
eladkal
approved these changes
Mar 7, 2023
Contributor
It will be in next release |
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #29002
When
get_logs=False, we should wait thebasecontainer completion before reading the xcom file, to do that we are checking if the container is running, but there is a possibility that the container is in waiting state, and in the currentawait_container_completionmethod, we consider it as completed.Instead, I'm checking if the container has the state
terminatedand if not I wait 1s.