Remove hard-coded executor reschedule mode coupling #28934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsharma2
requested review from
XD-DENG,
ashb,
dstandish,
jedcunningham,
kaxil and
o-nikolas
as code owners
boring-cyborg
bot
added
area:CLI
area:core-operators
provider:cncf-kubernetes
utkarsharma2
changed the title
o-nikolas
reviewed
Jan 16, 2023
o-nikolas
reviewed
Jan 16, 2023
Contributor
|
Hey @utkarsharma2! |
… into FixStandalone
utkarsharma2
requested review from
o-nikolas
and removed request for
XD-DENG,
ashb,
dstandish,
jedcunningham and
kaxil
Contributor
Author
|
Hey @o-nikolas, can you PTAL. |
o-nikolas
approved these changes
Jan 23, 2023
o-nikolas
changed the title
pierrejeambrun
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hard-coded coupling from the
Stand Alonecommand.Added a property
standalone_command_backendsto list all the supported databases by executors for the standalone command.Removed hard-coded coupling from the base sensors
Added a property
change_sensor_mode_to_rescheduleto indicate when we need to change the mode toreschedule.closes: #27929