Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check jenkins result state #28659

Merged
merged 23 commits into from
Jan 6, 2023
Merged

Conversation

tnyz
Copy link
Contributor

@tnyz tnyz commented Dec 31, 2022

Allow user to specify target states, add connection schema support in jenkins url

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal
Copy link
Contributor

eladkal commented Dec 31, 2022

Is this related to #28465 ?

@tnyz
Copy link
Contributor Author

tnyz commented Dec 31, 2022

No, I think what was described in that ticket is about scheme instead of schema scheme://user:password@host%2Flocation:1234/schema?__extra__=%7B%22my_val%22%3A+%5B%22list%22%2C+%22of%22%2C+%22values%22%5D%2

@tnyz
Copy link
Contributor Author

tnyz commented Jan 2, 2023

@eladkal any chance you can review this? thanks

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you need to fix CI errors.

airflow/providers/jenkins/hooks/jenkins.py Outdated Show resolved Hide resolved
airflow/providers/jenkins/sensors/jenkins.py Outdated Show resolved Hide resolved
@tnyz tnyz requested a review from uranusjr January 3, 2023 20:18
@uranusjr
Copy link
Member

uranusjr commented Jan 4, 2023

Need to fix static checks.

@tnyz
Copy link
Contributor Author

tnyz commented Jan 4, 2023

Need to fix static checks.

Good to merge

@tnyz tnyz requested a review from uranusjr January 5, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants