Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify log context setting / propagation handling #28571

Closed

Commits on Jan 27, 2023

  1. Don't disable propagation by default or walk logger tree with set_con…

    …text
    
    After apache#28440, instead of having a task logger both at `airflow.task` and root logger, we only have it at root logger.  This means we can remove the logic to set propagate to False, because there's no longer a risk of record processed by FTH twice.  It also means we can remove the logic to walk up the logger hierarchy and set context because we don't need to hit both airflow.task and root -- there will only ever be one such handler instance.  So in effect we deprecate the MAINTAIN_PROPAGATE logic and no longer set propagate=False by default.
    
    While we could probably remove the "DISABLE_PROPAGATE" logic too (it's only used by file processor) it doesn't really hurt to leave it.
    
    (cherry picked from commit b9ed441f9127503f55e338f728e68f10bc77f3df)
    dstandish committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    7ece9f4 View commit details
    Browse the repository at this point in the history