Skip to content

Re-enable pymsql on ARM as it now builds cleanly #28530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Dec 22, 2022
Merged

Re-enable pymsql on ARM as it now builds cleanly #28530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/providers/microsoft/mssql/provider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ versions:
dependencies:
- apache-airflow>=2.3.0
- apache-airflow-providers-common-sql>=1.3.1
- pymssql>=2.1.5; platform_machine != "aarch64"
- pymssql>=2.1.5

integrations:
- integration-name: Microsoft SQL Server (MSSQL)
Expand Down
2 changes: 1 addition & 1 deletion dev/breeze/src/airflow_breeze/commands/developer_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ def enter_shell(**kwargs) -> RunCommandResult:
sys.exit(1)
if shell_params.backend == "mssql":
get_console().print("\n[error]MSSQL is not supported on ARM architecture[/]\n")
return 1
sys.exit(1)
command_result = run_command(
cmd, env=env_variables, text=True, check=False, output_outside_the_group=True
)
Expand Down
2 changes: 1 addition & 1 deletion generated/provider_dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@
"deps": [
"apache-airflow-providers-common-sql>=1.3.1",
"apache-airflow>=2.3.0",
"pymssql>=2.1.5; platform_machine != \"aarch64\""
"pymssql>=2.1.5"
],
"cross-providers-deps": [
"common.sql"
Expand Down
2 changes: 1 addition & 1 deletion scripts/in_container/run_provider_yaml_files_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def check_if_object_exist(object_name: str, resource_type: str, yaml_file_path:
raise RuntimeError(f"Wrong enum {object_type}???")
except Exception as e:
if architecture == Architecture.ARM:
if "pymssql" in str(e) or "MySQLdb" in str(e):
if "MySQLdb" in str(e):
console.print(
f"[yellow]The imports fail on ARM: {object_name} in {resource_type} {e}, "
f"but it is expected.[/]"
Expand Down