Add deferrable mode to DataprocCreateClusterOperator and #28529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
kind:documentation
provider:google
pankajastro
reviewed
Dec 29, 2022
Member
There was a problem hiding this comment.
does it make sense to extend this class from DataprocBaseTrigger instead of BaseTrigger https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/triggers/dataproc.py#L31 WDYT?
Contributor
Author
There was a problem hiding this comment.
DataprocBaseTrigger is dedicated to e.g. DataprocSubmitJobOperator.
I changed the name to DataprocSubmitTrigger for clarity.
bkossakowska
force-pushed
the
dataproc_cluster_def_mode
branch
2 times, most recently
from
0df73f9 to
26dbf3b
Compare
Member
|
Conflicts :( |
bkossakowska
force-pushed
the
dataproc_cluster_def_mode
branch
2 times, most recently
from
a0559fa to
9606104
Compare
…teClusterOperator
bkossakowska
force-pushed
the
dataproc_cluster_def_mode
branch
from
9606104 to
ca9d695
Compare
potiuk
approved these changes
Jan 25, 2023
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataprocUpdateClusterOperator
Add deferrable mode to DataprocCreateClusterOperator and DataprocUpdateClusterOperator
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.