Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate logs to stdout when in k8s executor pod #28440

Merged
merged 47 commits into from
Jan 9, 2023
Merged

Propagate logs to stdout when in k8s executor pod #28440

merged 47 commits into from
Jan 9, 2023

Commits on Jan 4, 2023

  1. Propagate logs to stdout when in k8s executor pod 

    This is necessary because file task handler reads from pod logs (i.e. stdout) when pod is running.

Previously we were not propagating task logs, presumably to avoid duplicating entries, because we had copied the handler to root.  However, if we just remove the handler from task, we can safely enable propagation, since there won't be multiple task handlers floating around.
    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    febf15f View commit details
    Browse the repository at this point in the history

  2. don't caputure stdout unless in local task

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    170402e View commit details
    Browse the repository at this point in the history

  3. don't modify handlers or redirect stdout if already done

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    f867323 View commit details
    Browse the repository at this point in the history

  4. don't modify handlers or redirect stdout if already done

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    c0301cd View commit details
    Browse the repository at this point in the history

  5. add test

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    3947617 View commit details
    Browse the repository at this point in the history

  6. refactor test

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    cba5be4 View commit details
    Browse the repository at this point in the history

  7. restore try / finally

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    b744c41 View commit details
    Browse the repository at this point in the history

  8. resolve failing tests

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    1b4e967 View commit details
    Browse the repository at this point in the history

  9. try fixing test again

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    54124d2 View commit details
    Browse the repository at this point in the history

  10. actually fix test

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    beaf6df View commit details
    Browse the repository at this point in the history

  11. actually _actually_ fix test

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    71f270b View commit details
    Browse the repository at this point in the history

  12. improve readability of move handlers ctxmgr

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    937535c View commit details
    Browse the repository at this point in the history

  13. remove modify indent too

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    3e7baa8 View commit details
    Browse the repository at this point in the history

  14. simplify tests

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    9face81 View commit details
    Browse the repository at this point in the history

  15. fixup

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    8602005 View commit details
    Browse the repository at this point in the history

  16. fix test

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    ac3bfd4 View commit details
    Browse the repository at this point in the history

  17. mock fth render filename

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    9817191 View commit details
    Browse the repository at this point in the history

  18. remove FTH mock and supply session to get_template_context

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    b980c01 View commit details
    Browse the repository at this point in the history

  19. move reconfigure below context init

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    6c0dbe0 View commit details
    Browse the repository at this point in the history

  20. not fixture

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    095a509 View commit details
    Browse the repository at this point in the history

  21. simplify

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    6aa0dfc View commit details
    Browse the repository at this point in the history

  22. fixup

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    0f54b60 View commit details
    Browse the repository at this point in the history

  23. add helper for moving logger attrs

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    59bdf38 View commit details
    Browse the repository at this point in the history

  24. move lower

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    a032e2c View commit details
    Browse the repository at this point in the history

  25. rename mutation helper

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    650220f View commit details
    Browse the repository at this point in the history

  26. doc

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    65ebef6 View commit details
    Browse the repository at this point in the history

  27. clarify

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    52ce222 View commit details
    Browse the repository at this point in the history

  28. cosmetic

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    c0ceed0 View commit details
    Browse the repository at this point in the history

  29. context mgr

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    9adb850 View commit details
    Browse the repository at this point in the history

  30. simplify

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    dd0f252 View commit details
    Browse the repository at this point in the history

  31. simplify

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    0adb2b3 View commit details
    Browse the repository at this point in the history

  32. simplify

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    590b3f5 View commit details
    Browse the repository at this point in the history

  33. typo

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    486d5b5 View commit details
    Browse the repository at this point in the history

  34. simplify

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    4f8aeea View commit details
    Browse the repository at this point in the history

  35. simplify

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    67bc6a7 View commit details
    Browse the repository at this point in the history

  36. simplify

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    7e148b5 View commit details
    Browse the repository at this point in the history

  37. don't check TI

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    1a9db65 View commit details
    Browse the repository at this point in the history

  38. set private

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    6b8b153 View commit details
    Browse the repository at this point in the history

  39. inline some code

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    6280275 View commit details
    Browse the repository at this point in the history

  40. fix tests

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    776b819 View commit details
    Browse the repository at this point in the history

  41. static check

    @dstandish
    dstandish committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    0d4a208 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Update tests/cli/commands/test_task_command.py 

    Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
    @dstandish @ashb
    dstandish and ashb authored Jan 9, 2023
    Configuration menu
    Copy the full SHA
    777dd4e View commit details
    Browse the repository at this point in the history

  2. remove freeze time

    @dstandish
    dstandish committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    1c1f1c9 View commit details
    Browse the repository at this point in the history

  3. Update tests/task/task_runner/test_standard_task_runner.py 

    Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
    @dstandish @ashb
    dstandish and ashb authored Jan 9, 2023
    Configuration menu
    Copy the full SHA
    49228a2 View commit details
    Browse the repository at this point in the history

  4. Update airflow/utils/log/file_task_handler.py 

    Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
    @dstandish @ashb
    dstandish and ashb authored Jan 9, 2023
    Configuration menu
    Copy the full SHA
    1695b44 View commit details
    Browse the repository at this point in the history

  5. remove freeze time

    @dstandish
    dstandish committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    da74320 View commit details
    Browse the repository at this point in the history

  6. fix whitespace

    @dstandish
    dstandish committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    b7e8d7c View commit details
    Browse the repository at this point in the history