-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New AWS sensor — DynamoDBValueSensor #28338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
@o-nikolas Please review at your convenience. Thanks. |
|
This is marked as a draft, do you want a review on it or are you still working on it? |
airflow/providers/amazon/aws/example_dags/example_dynamodb_sensor.py
Outdated
Show resolved
Hide resolved
|
@ferruzzi Yes please review. @o-nikolas suggested I create as a draft to limit visibility. Thanks! |
|
Hey @mrichman, Any plans to make more progress on this one? |
|
@o-nikolas Yes indeed, just haven't come up for air with all my new customers. It's definitely toward the top of my (ever growing) todo list. |
ferruzzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two non-blocking ideas. Once the tests pass, I'm happy to approve.
|
@ferruzzi Am I to use |
It should be in If file doesn't exist then create it. |
|
What Elad said 😄 Basically just replace the |
ferruzzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good.
o-nikolas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I just triggered another build, if it goes green I'll merge :)
|
Just approved another build on the latest changes! 🤞 |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
Nice, congrats! |
|
Indeed. |
|
congrats on the first contribution @mrichman!! |

DynamoDBValueSensor waits for an attribute value to be present for an item in a DynamoDB table.