Migrate remaining core sensors tests to pytest
#28177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
commented
Dec 6, 2022
Comment on lines
-169
to
+170
| timeout=1, | ||
| timeout=0.001, | ||
| dag=self.dag, | ||
| poke_interval=0.1, |
Contributor
Author
There was a problem hiding this comment.
Default poke_interval is 60 second as result test wait 1 minute for timeout exception.
Contributor
Author
|
really strange error in test. I assume that some other test could change in logging and do not teardown correctly. |
uranusjr
approved these changes
Dec 7, 2022
potiuk
approved these changes
Dec 7, 2022
Contributor
Author
Member
|
I must have merged it by mistake, not seeing the failures. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 7, 2022
This reverts commit 529f11b.
Member
Member
|
@Taragolis #28193 (comment) these two tests together (prior to the revert) fail |
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up with migration remaining unittests TestCases in core to pytest
Include just sensors because found long running test in it which actually could run less than second