Skip to content

Conversation

@lucasfcnunes
Copy link
Contributor


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Dec 6, 2022
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@uranusjr
Copy link
Member

uranusjr commented Dec 6, 2022

Oh we need a test case for this.

@eladkal
Copy link
Contributor

eladkal commented Jan 9, 2023

@lucasfcnunes can you please add unit test?

@eladkal
Copy link
Contributor

eladkal commented Feb 17, 2023

closing in favor of #29477

@eladkal eladkal closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants