Skip to content

Add volume-related nested template fields for KPO #27719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Dec 3, 2022
Merged

Add volume-related nested template fields for KPO #27719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b12f1f2
[FEATURE] KPO - volume nested template fields
raphaelauv Nov 16, 2022
ef3df1c
review
raphaelauv Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ class KubernetesPodOperator(BaseOperator):
"pod_template_file",
"namespace",
"container_resources",
"volumes",
"volume_mounts",
)
template_fields_renderers = {"env_vars": "py"}

Expand Down Expand Up @@ -316,15 +318,28 @@ def _render_nested_template_fields(
jinja_env: jinja2.Environment,
seen_oids: set,
) -> None:
if id(content) not in seen_oids and isinstance(content, k8s.V1EnvVar):
seen_oids.add(id(content))
self._do_render_template_fields(content, ("value", "name"), context, jinja_env, seen_oids)
return

if id(content) not in seen_oids and isinstance(content, k8s.V1ResourceRequirements):
seen_oids.add(id(content))
self._do_render_template_fields(content, ("limits", "requests"), context, jinja_env, seen_oids)
return
if id(content) not in seen_oids:
template_fields: tuple | None = None

if isinstance(content, k8s.V1EnvVar):
template_fields = ("value", "name")

if isinstance(content, k8s.V1ResourceRequirements):
template_fields = ("limits", "requests")

if isinstance(content, k8s.V1Volume):
template_fields = ("name", "persistent_volume_claim")

if isinstance(content, k8s.V1VolumeMount):
template_fields = ("name",)

if isinstance(content, k8s.V1PersistentVolumeClaimVolumeSource):
template_fields = ("claim_name",)

if template_fields:
seen_oids.add(id(content))
self._do_render_template_fields(content, template_fields, context, jinja_env, seen_oids)
return

super()._render_nested_template_fields(content, context, jinja_env, seen_oids)

Expand Down