Fix Azure Batch errors revealed by added typing to azure batch lib #27601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
potiuk
force-pushed
the
fix-static-errors-for-azure-batch
branch
from
338ec50 to
b647d6d
Compare
jedcunningham
approved these changes
Nov 10, 2022
ephraimbuddy
approved these changes
Nov 10, 2022
eladkal
approved these changes
Nov 10, 2022
The Azure batch library added typing and it revealed a few potential (or even not that potential) bugs that needed to be fixed. * implicit optional is added for azure.batch as they use it * some of the parameters are required rather than optional and we needed to change them from optional in our Hooks * some fields were wrongly scoped
potiuk
force-pushed
the
fix-static-errors-for-azure-batch
branch
from
b647d6d to
4982d3e
Compare
Member
Author
|
Merging. Static checks passed. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 10, 2022
The apache#27601 also needs fix in test cases.
ephraimbuddy
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Nov 10, 2022
The #27601 also needs fix in test cases.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 10, 2022
The apache#27601 also needs fix in Hook test cases.
potiuk
added a commit
that referenced
this pull request
Nov 10, 2022
The #27601 also needs fix in Hook test cases.
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 11, 2022
Adityamalik123
pushed a commit
to Adityamalik123/airflow
that referenced
this pull request
Nov 12, 2022
…pache#27601) The Azure batch library added typing and it revealed a few potential (or even not that potential) bugs that needed to be fixed. * implicit optional is added for azure.batch as they use it * some of the parameters are required rather than optional and we needed to change them from optional in our Hooks * some fields were wrongly scoped
Adityamalik123
pushed a commit
to Adityamalik123/airflow
that referenced
this pull request
Nov 12, 2022
The apache#27601 also needs fix in test cases.
Adityamalik123
pushed a commit
to Adityamalik123/airflow
that referenced
this pull request
Nov 12, 2022
The apache#27601 also needs fix in Hook test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure batch library added typing and it revealed a few potential (or even not that potential) bugs that needed to be fixed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.