Add container_resources as KubernetesPodOperator templatable #27457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
alanatlemba
changed the title
KubernetesPodOperator add container_resources as templated field
Contributor
Author
|
FYI @eladkal @jedcunningham @potiuk (rebased) |
eladkal
reviewed
Nov 3, 2022
eladkal
reviewed
Nov 3, 2022
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py
Outdated
Show resolved
Hide resolved
potiuk
approved these changes
Nov 7, 2022
uranusjr
reviewed
Nov 7, 2022
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py
Outdated
Show resolved
Hide resolved
…inja templates.
…s time (fixes static checks)
alanatlemba
force-pushed
the
feature/k8s-pod-templated-resources
branch
from
de3386d to
534e277
Compare
uranusjr
approved these changes
Nov 9, 2022
Contributor
Author
|
All checks passed! I am basically a god. |
uranusjr
changed the title
KubernetesPodOperator add container_resources as templated field
|
Awesome work, congrats on your first merged pull request! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #23529
This is my first PR (#26982) closed by accident when I rebased my fork. That was my first PR for a mainstream large scale open source project, let alone Airflow.
Sorry in advance if I've done anything improper, and thanks for your patience.
Thank you @nitinmuteja & @lior1990 for doing much of the work. This is following up on this closed/abandoned PR: #23531
Here is how I tested:
breeze testing tests --test-type "Providers[cncf]"^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.