-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Use new job search API for triggering Databricks job by name #27446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new job search API for triggering Databricks job by name #27446
Conversation
|
Instead of explicit parameter we can check for presence of an environment variable. Not sure what is the best way, especially when we depreciate old implementation completely |
Could you not attempt to make the new API request and then handle the error/exception you get back if it isn't supported by the backend being used, then automatically fall back to the old api in that case? |
|
@o-nikolas it's not really a completely new API, it's a new parameter to that API. If API doesn't support that parameter it just returns all data as before... |
If that's the case, then it should be easy to build this in a backwards compatible way without the |
Existing implementation uses list API to find all possible jobs and filtering out them by name. This leads to huge load on the API backend for workspaces with big number of jobs (> 1k). Databricks Workflows team extended list API with search functionality.
c464aad to
3dc2d7c
Compare
|
I've reimplemented it differently, so old review comments aren't much relevant |
|
Hmmm, not sure if it fails in static check... Looks like |
|
@ephraimbuddy comments are addressed & |
…27446) * Use new job search API for triggering Databricks job by name Existing implementation uses list API to find all possible jobs and filtering out them by name. This leads to huge load on the API backend for workspaces with big number of jobs (> 1k). Databricks Workflows team extended list API with search functionality. * address review comments * fix mypy error
Existing implementation uses list API to find all possible jobs and filtering out them by name. This leads to huge load on the API backend for workspaces with big number of jobs (> 1k). Databricks Workflows team extended list API with search functionality.