Add better diagnostics on auto dependencies upgrade #27215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever upgrade-to-newer-dependencies is set, our CI will attempt to upgrade all dependencies to latest versions released. However so far it was not clear which dependencies were upgraded so if CI failed because of some dependency release, you had to guess and manually check which dependencies got upgraded. This PR adds a step that will show the diff between the constraints in the target branch (`constraints-main` or `constraints-X-Y` in case upgrade-to-newer-dependencies is enabled.
eladkal
approved these changes
Oct 23, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 23, 2022
It turnded out that apache#27215 has a problem when runnning when in-workflow-build is False - additional condition has to be added for it. Additionally, the constraint generation is run for all python versions in parallel instaed of running only for default python version.
potiuk
added a commit
that referenced
this pull request
Oct 23, 2022
It turnded out that #27215 has a problem when runnning when in-workflow-build is False - additional condition has to be added for it. Additionally, the constraint generation is run for all python versions in parallel instaed of running only for default python version.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 25, 2022
Build images uses different parameter than ci.yml for building the images (all-python* instead of python*). This is to account for the fact that we only have one build-image.yml workflow for all airflow versions (in main) and we need to account for the fact that different versions of airflow will have support for different Python versions. This was not happening for a while, but it will soon start being needed for Python 3.11 that will be supported in 2.5 but not supported in 3.11. By mistake apache#27215 added displaying of upgraded dependencies with wrong parameter name in build-images.yml copied from ci.yml that caused a problem for PRs that were changing dependencies but did not trigger full build.
potiuk
added a commit
that referenced
this pull request
Oct 25, 2022
Build images uses different parameter than ci.yml for building the images (all-python* instead of python*). This is to account for the fact that we only have one build-image.yml workflow for all airflow versions (in main) and we need to account for the fact that different versions of airflow will have support for different Python versions. This was not happening for a while, but it will soon start being needed for Python 3.11 that will be supported in 2.5 but not supported in 3.11. By mistake #27215 added displaying of upgraded dependencies with wrong parameter name in build-images.yml copied from ci.yml that caused a problem for PRs that were changing dependencies but did not trigger full build.
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
Whenever upgrade-to-newer-dependencies is set, our CI will attempt to upgrade all dependencies to latest versions released. However so far it was not clear which dependencies were upgraded so if CI failed because of some dependency release, you had to guess and manually check which dependencies got upgraded. This PR adds a step that will show the diff between the constraints in the target branch (`constraints-main` or `constraints-X-Y` in case upgrade-to-newer-dependencies is enabled. (cherry picked from commit 8f5ed4b)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
It turnded out that #27215 has a problem when runnning when in-workflow-build is False - additional condition has to be added for it. Additionally, the constraint generation is run for all python versions in parallel instaed of running only for default python version. (cherry picked from commit e789a2b)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
Whenever upgrade-to-newer-dependencies is set, our CI will attempt to upgrade all dependencies to latest versions released. However so far it was not clear which dependencies were upgraded so if CI failed because of some dependency release, you had to guess and manually check which dependencies got upgraded. This PR adds a step that will show the diff between the constraints in the target branch (`constraints-main` or `constraints-X-Y` in case upgrade-to-newer-dependencies is enabled. (cherry picked from commit 8f5ed4b)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
It turnded out that #27215 has a problem when runnning when in-workflow-build is False - additional condition has to be added for it. Additionally, the constraint generation is run for all python versions in parallel instaed of running only for default python version. (cherry picked from commit e789a2b)
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
Whenever upgrade-to-newer-dependencies is set, our CI will attempt to upgrade all dependencies to latest versions released. However so far it was not clear which dependencies were upgraded so if CI failed because of some dependency release, you had to guess and manually check which dependencies got upgraded. This PR adds a step that will show the diff between the constraints in the target branch (`constraints-main` or `constraints-X-Y` in case upgrade-to-newer-dependencies is enabled. (cherry picked from commit 8f5ed4b)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
It turnded out that #27215 has a problem when runnning when in-workflow-build is False - additional condition has to be added for it. Additionally, the constraint generation is run for all python versions in parallel instaed of running only for default python version. (cherry picked from commit e789a2b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever upgrade-to-newer-dependencies is set, our CI will attempt to upgrade all dependencies to latest versions released. However so far it was not clear which dependencies were upgraded so if CI failed because of some dependency release, you had to guess and manually check which dependencies got upgraded.
This PR adds a step that will show the diff between the constraints in the target branch (
constraints-mainorconstraints-X-Yin case upgrade-to-newer-dependencies is enabled.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.