-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Drop support for providing resource as dict in KubernetesPodOperator
#27197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
85d1a4a to
43c66b0
Compare
dstandish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comment but approving anyway
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Test needs fixing though.
6429678 to
1251b58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also remove this module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any more usage in the code to convert_resources so I removed it.
I think we should remove the whole backward compact module but it needs more close look on the other functions
|
ok so to fix.... first of all, actual vs expected needs to be flipped in those asserts then this needs to be removed from the "expeced" (really just remove that line should do it, can leave the assert flipping for another time since it's tough for you to test locally) |
|
CI is green :) |

Dropping support for resource parameter
Deprecation added in #24673
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.