Skip to content

Conversation

@nivaldoh
Copy link
Contributor

closes: #27093

Adds documentation for the following Google Cloud transfer operators: BigQueryToBigQueryOperator, BigQueryToGCSOperator, BigQueryToMsSqlOperator, BigQueryToMySqlOperator, GCSToBigQueryOperator


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@nivaldoh nivaldoh requested a review from mik-laj as a code owner October 20, 2022 02:00
@boring-cyborg boring-cyborg bot added area:providers kind:documentation provider:google Google (including GCP) related issues labels Oct 20, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 20, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@nivaldoh nivaldoh marked this pull request as draft October 20, 2022 02:25
@nivaldoh nivaldoh force-pushed the document_bq_transfer_ops branch 2 times, most recently from b2f2051 to 52f7016 Compare October 22, 2022 18:26
Comment on lines 35 to 58
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrate the GCSToBigQueryOperator to its own page to maintain the established pattern for transfer operators.

Comment on lines 51 to 59
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use example in the docstring as BigQueryToMySqlOperator doesn't have its own system test, and creating one may not be necessary.

@nivaldoh nivaldoh marked this pull request as ready for review October 22, 2022 19:01
@nivaldoh nivaldoh requested a review from turbaszek as a code owner October 22, 2022 19:01
@nivaldoh
Copy link
Contributor Author

@turbaszek @mik-laj Ready for review at your earliest convenience.

@potiuk
Copy link
Member

potiuk commented Oct 31, 2022

Let's see if CI passes.

@potiuk
Copy link
Member

potiuk commented Oct 31, 2022

Some static checks are failing - you need to solve and rebase.

@nivaldoh nivaldoh force-pushed the document_bq_transfer_ops branch from 5e91cfc to 2266ff7 Compare November 8, 2022 04:25
@nivaldoh
Copy link
Contributor Author

nivaldoh commented Nov 8, 2022

Thanks for the review. All points have been addressed.

@potiuk
Copy link
Member

potiuk commented Nov 11, 2022

docs are failing.

@potiuk
Copy link
Member

potiuk commented Nov 17, 2022

?

@eladkal
Copy link
Contributor

eladkal commented Dec 1, 2022

@nivaldoh can you please address the doc test failures?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 20, 2023
@shahar1
Copy link
Contributor

shahar1 commented Jan 23, 2023

@eladkal Please assign me

@potiuk
Copy link
Member

potiuk commented Jan 23, 2023

@eladkal Please assign me

You can just take the PR and start working on yours (and make reference to this PR). There is no need to assign it.

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 24, 2023
@eladkal
Copy link
Contributor

eladkal commented Feb 11, 2023

resolved in #29466

@eladkal eladkal closed this Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing documentation for GCP BigQuery transfer operators

4 participants