Fix example_emr_serverless system test #27149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
provider:amazon
eladkal
reviewed
Oct 20, 2022
| return_code = int(e.response['Error']['Code']) | ||
| if return_code == 404: | ||
| self.log.error('Bucket "%s" does not exist', bucket_name) | ||
| self.log.info('Bucket "%s" does not exist', bucket_name) |
Contributor
There was a problem hiding this comment.
why do we change log level only for 404?
Contributor
Author
There was a problem hiding this comment.
Well. If it's 403 the bucket exists but the user does not have permissions so I think it makes sense to log an error for that use case
Contributor
Author
There was a problem hiding this comment.
On the other side, 404 is a very valid use case. If the bucket exists (and user has permissions), we should not log an error for that
o-nikolas
approved these changes
Oct 25, 2022
eladkal
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
example_emr_serverlesssystem test. EMR does not allow cross region calls. The region was hardcoded for a S3 file tous-east-1. Any execution of this system test outside ofus-east-1results in a failure.