Allow no extra prefix in yandex hook #27040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From 2.3 this is supported, so we update to generally not use the extra prefix but maintain backcompat.
ferruzzi
reviewed
Oct 20, 2022
| if not hasattr(self, 'extras'): | ||
| return default | ||
| backcompat_prefix = 'extra__yandexcloud__' | ||
| if field_name.startswith('extra_'): |
Contributor
There was a problem hiding this comment.
Non-blocking suggestion, is there a reason to not use startswith(backcompat_prefix)?
Contributor
There was a problem hiding this comment.
It actually looks like you id this in some of the newer ones.
ferruzzi
approved these changes
Oct 20, 2022
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Left a non-blocking suggestion, but otherwise LGTM
eladkal
approved these changes
Oct 22, 2022
dstandish
commented
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 2.3 this is supported, so we update to generally not use the extra prefix but maintain backcompat.