Skip to content

Conversation

@Voldurk
Copy link
Contributor

@Voldurk Voldurk commented Oct 13, 2022

  • _wait_for_states() fix
  • _get_current_jobs() and cancel() adjustment to allow stopping multiple jobs by name
  • New operator: DataflowStopJobOperator
  • Removed batch request from cancel() method as it was not working for gogleapis.dataflow.v1b3.projects.locations.jobs.update

Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of an existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Oct 13, 2022
@Voldurk Voldurk marked this pull request as ready for review October 13, 2022 18:40
@Voldurk Voldurk requested a review from turbaszek as a code owner October 13, 2022 18:40
@potiuk
Copy link
Member

potiuk commented Oct 23, 2022

Looks good, but could you please make a Howto example (see howto_operator_start_template_job as example on how you can do it - look in the documentation for google providers.

@Voldurk Voldurk requested a review from mik-laj as a code owner October 28, 2022 11:21
@Voldurk
Copy link
Contributor Author

Voldurk commented Oct 28, 2022

@potiuk Updated. Not sure what I can do about that 'unhealthy container' on sql server test.

@potiuk
Copy link
Member

potiuk commented Oct 31, 2022

Ignore (for now - this is on our flaky-list-to-solve)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants