PostgresHook: Added ON CONFLICT DO NOTHING statement when all target fields are primary keys #26661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mary keys. Also made _generate_insert_sql use cls.placeholder for standarization sake
uranusjr
reviewed
Sep 26, 2022
Member
Contributor
Author
uranusjr
approved these changes
Nov 10, 2022
potiuk
approved these changes
Nov 10, 2022
Adityamalik123
pushed a commit
to Adityamalik123/airflow
that referenced
this pull request
Nov 12, 2022
…fields are primary keys (apache#26661) Added ON CONFLICT DO NOTHING statement when all target fields are primary keys. Also made _generate_insert_sql use cls.placeholder for standarization sake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ON CONFLICT DO NOTHING statement when
replace=Trueand all target fields are primary keys.Also made
_generate_insert_sql()usecls.placeholderfor standardization sake.Previously, if all inserted columns were primary keys, the generated SQL statement would not be syntactically correct.