Clearer code for PodGenerator.deserialize_model_file #26641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:cncf-kubernetes
XD-DENG
commented
Sep 23, 2022
XD-DENG
force-pushed
the
improve-model-deserialize
branch
2 times, most recently
from
89979fe to
70499c6
Compare
XD-DENG
force-pushed
the
improve-model-deserialize
branch
4 times, most recently
from
f77daa7 to
9ee336d
Compare
Especially for how it handles non-existent file. When the file path received doesn't exist, the current way is to use yaml.safe_load() to process it, and it returns the path as a string. Then this string is passed to deserialize_model_dict() and results in an empty object. Passing 'None' to deserialize_model_dict() will do the same, but the code will become clearer, and less misleading. Meanwhile, when the model file path received doesn't exist, there should be a warning in the log. (This change shouldn't cause any behaviour change)
XD-DENG
force-pushed
the
improve-model-deserialize
branch
from
9ee336d to
c01e739
Compare
|
Hi @ashb , adding you as reviewer for this since you reviewed & co-authored the original change. Pls let me know if this is making sense to you or additional info needed. Thanks! |
uranusjr
reviewed
Sep 25, 2022
uranusjr
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially for how it handles non-existent file.
When the file path received doesn't exist, the current way is to use yaml.safe_load() to process it, and it returns the path as a string.
Then this string is passed to deserialize_model_dict() and results in an empty object. Passing 'None' to deserialize_model_dict() will do the same, but the code will become clearer, and less misleading.
Meanwhile, when the model file path received doesn't exist, there should be a warning in the log.
(This change shouldn't cause any behaviour change)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.