Flag to deserialize value on custom XCom backend #26343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional 'deserialize=true' query param to the XCom entry retrieval endpoint. When set, the webserver would call deserialize_value against the XCom entry, instead of the cheaper orm_deserialize_value, for the user to retrieve the "real" XCom value.
uranusjr
requested review from
ashb,
bbovenzi,
ephraimbuddy,
mik-laj and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
ashb
approved these changes
Sep 12, 2022
potiuk
pushed a commit
that referenced
this pull request
Sep 14, 2022
(cherry picked from commit ffee6bc)
Member
|
Hey @uranusjr - FYI I cherry-picked that one also to 2.4.0 as the only change needed to synchronize 2.4 branch and PEP-563 changes |
Member
Author
|
Thie one marks the new addition as New in 2.5.0, if it’s being cherry-picked into 2.4 that needs to changed. |
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 14, 2022
(cherry picked from commit ffee6bc)
Contributor
|
@uranusjr I intend to remove this feature as I think this is potentially a security issue in the webserver, particularly after #27540 gets merged which |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional
deserialize=truequery param to the XCom entry retrieval endpoint. When set, the webserver would calldeserialize_valueagainst the XCom entry, instead of the cheaperorm_deserialize_value, for the user to retrieve the "real" XCom value.Fix #26174.