Fix : SFTP Sensor fails to locate file when file_pattern is provided

[ajinkya-xyz]

Background : Pull request # 24084 added the ability to provide fnamtch file pattern to SFTP sensor. But sensor fails to locate the file when the file pattern is provided.

Issue : Code fails to get modified time once file matching to the given pattern is found. Line # 77 from sftp.py file fails with no such file error.

mod_time = self.hook.get_mod_time(actual_file_to_check)

Root cause: Code assumes that the get_file_by_pattern method returns a complete path for a file matching the given fnamtch expression. While we are only getting file name in return. get_file_by_pattern internally relies on Paramiko SFTP clients listdir() method to retrieve files contained in given path folder. listdir() method only returns file names and not the complete file path.

Related code, sftp.py file line # 68.
file_from_pattern = self.hook.get_file_by_pattern(self.path, self.file_pattern)

Fix : Prepending the path to actual_file_to_check variable fixes the issue.

actual_file_to_check = os.path.join(self.path, file_from_pattern)

Related : 24084

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

It seems like the tests need some work to fix temp file usasges.

[potiuk]

Yep. Fix would be nice here.

[ajinkya-xyz]

@uranusjr @potiuk Facing issue in doing local setup on windows machine. Will try to spend some time on weekend.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.